Re: [PATCH 1/6] Thread pointer built-in functions, core parts

[Chung-Lin Tang]

On 2012/7/13 02:37 AM, Richard Sandiford wrote:
>> +void
>> > +default_expand_builtin_set_thread_pointer (rtx val ATTRIBUTE_UNUSED)
>> > +{
>> > +  sorry ("__builtin_set_thread_pointer() not available for this target");
>> > +}
> Function names should be quoted by %< %>.  But maybe we can save the
> translators some work and use:
> 
>   sorry ("%qs is not available for this target", 
> "__builtin_thread_pointer()");
> ...
>   sorry ("%qs is not available for this target",
>          "__builtin_set_thread_pointer()");

Seeing default_expand_builtin_saveregs() as a current example, using %qs
sort of diverges from the style, though I'm not sure if that should be
changed too...personally I think unquoted looks cleaner :)

Another small detail, should '()' be included with the function name in
the diagnostic message?

Thanks,
Chung-Lin