Re: [committed] — was: [Patch] OpenMP/C++: Fix declare variant with reference-returning functions

[Tobias Burnus]

Hi Jakub,

Jakub Jelinek wrote:

+  if (TREE_CODE (variant) == INDIRECT_REF)
+    variant = TREE_OPERAND (variant, 0);
+
    variant = cp_get_callee_fndecl_nofold (variant);

I think this should be just
   variant = cp_get_callee_fndecl_nofold (STRIP_REFERENCE_REF (variant));
instead.

… which clearly shows that I only know the C++ FE superficially.

Yes, while at the end identical, that reads much nicer!
Thanks for the suggestion → commit r15-4801-gf7ae087ef0132b

Tobias