On Sat, 26 Oct 2024, Martin Uecker wrote:
> +tree
> +c_build_pointer_type (tree to_type)
> +{
> + addr_space_t as = to_type == error_mark_node? ADDR_SPACE_GENERIC
> + : TYPE_ADDR_SPACE (to_type);
This is badly formatted, missing space before '?'.
> +/* Build an array type. This sets typeless storage as required
> + by C23 and C_TYPE_VARIABLY_MODIFIED and C_TYPE_VARIABLE_SIZE
> + based on the element type and domain. */
As required by C2Y, not C23.
> + else if (TREE_CODE (type) == REFERENCE_TYPE
> + || TREE_CODE (type) == OFFSET_TYPE)
> + {
> + gcc_assert (0);
> + }
Should be gcc_unreachable (), and no braces around a single statement.
> diff --git a/gcc/testsuite/gcc.dg/Wvla-parameter-2.c
> b/gcc/testsuite/gcc.dg/Wvla-parameter-2.c
> index daa71d897c9..ebd61522563 100644
> --- a/gcc/testsuite/gcc.dg/Wvla-parameter-2.c
> +++ b/gcc/testsuite/gcc.dg/Wvla-parameter-2.c
> @@ -37,14 +37,10 @@ void f (int[n1][2][n3][4][n5][6][n7][8][n9]);
> /* Due to a limitation and because [*] is represented the same as [0]
> only the most significant array bound is rendered as [*]; the others
> are rendered as [0]. */
This "Due to a limitation" comment should be updated / removed to reflect
the changes to representation of [*].
OK with those fixes.
--
Joseph S. Myers
josmy...@redhat.com
