On Fri, 25 Oct 2024, Jakub Jelinek wrote: > Hi! > > On Thu, Oct 24, 2024 at 03:33:25PM -0400, Eric Gallager wrote: > > On Thu, Oct 24, 2024 at 4:17 AM Jakub Jelinek <ja...@redhat.com> wrote: > > > I've tried to build stage3 with > > > -Wleading-whitespace=blanks -Wtrailing-whitespace=blank > > > -Wno-error=leading-whitespace=blanks -Wno-error=trailing-whitespace=blank > > > > So wait, it's "blanks" (plural) when it's leading, but "blank" > > (singular) when it's trailing? That inconsistency bothers me... > > I've mentioned it already in > https://gcc.gnu.org/pipermail/gcc-patches/2024-October/664664.html > Citing that here: > Not sure about the kinds for the option, given -Wleading-whitespace= > uses plural and this option singular and -Wleading-whitespace= spaces > means literally just ' ' characters, while space in > -Wtrailing-whitespace= was ' ', '\t', '\v' and '\f'; so category; > perhaps just use any and blanks? > Other preferences? > > Here is a patch to do the blank->blanks and space->any changes.
OK. -- Joseph S. Myers josmy...@redhat.com
