On Thu, 24 Oct 2024 at 15:45, Jonathan Wakely <jwak...@redhat.com> wrote: > > These tests check `_GLIBCXX_DOUBLE_IS_IEEE_BINARY128` but that's never > defined, it should be "LDOUBLE" not "DOUBLE". > > libstdc++-v3/ChangeLog: > > * testsuite/26_numerics/complex/ext_c++23.cc: Fix typo in macro. > * testsuite/26_numerics/headers/cmath/constexpr_std_c++23.cc: > Likewise. > * testsuite/26_numerics/headers/cmath/functions_std_c++23.cc: > Likewise. > * testsuite/26_numerics/headers/cmath/nextafter_c++23.cc: > Likewise. > --- > This first patch is an obvious fix for a typo, but tests still pass > after fixing it, which is reassuring! > > I'll push it shortly.
PATCH 1/3 is now pushed. The patch series is also available at https://forge.sourceware.org/gcc/gcc-TEST/pulls/6/files > > Tested powerpc64le-linux. > > libstdc++-v3/testsuite/26_numerics/complex/ext_c++23.cc | 2 +- > .../testsuite/26_numerics/headers/cmath/constexpr_std_c++23.cc | 2 +- > .../testsuite/26_numerics/headers/cmath/functions_std_c++23.cc | 2 +- > .../testsuite/26_numerics/headers/cmath/nextafter_c++23.cc | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libstdc++-v3/testsuite/26_numerics/complex/ext_c++23.cc > b/libstdc++-v3/testsuite/26_numerics/complex/ext_c++23.cc > index 0fc3d6f1a66..5f4ff06448e 100644 > --- a/libstdc++-v3/testsuite/26_numerics/complex/ext_c++23.cc > +++ b/libstdc++-v3/testsuite/26_numerics/complex/ext_c++23.cc > @@ -70,7 +70,7 @@ main() > } > #endif > #if defined(__STDCPP_FLOAT128_T__) \ > - && (defined(_GLIBCXX_DOUBLE_IS_IEEE_BINARY128) \ > + && (defined(_GLIBCXX_LDOUBLE_IS_IEEE_BINARY128) \ > || defined(_GLIBCXX_HAVE_FLOAT128_MATH)) > { > std::float128_t p[2] = {}; > diff --git > a/libstdc++-v3/testsuite/26_numerics/headers/cmath/constexpr_std_c++23.cc > b/libstdc++-v3/testsuite/26_numerics/headers/cmath/constexpr_std_c++23.cc > index 3c2377fd698..983027ff654 100644 > --- a/libstdc++-v3/testsuite/26_numerics/headers/cmath/constexpr_std_c++23.cc > +++ b/libstdc++-v3/testsuite/26_numerics/headers/cmath/constexpr_std_c++23.cc > @@ -119,7 +119,7 @@ main() > test_functions<std::float64_t>(); > #endif > #if defined(__STDCPP_FLOAT128_T__) \ > - && (defined(_GLIBCXX_DOUBLE_IS_IEEE_BINARY128) \ > + && (defined(_GLIBCXX_LDOUBLE_IS_IEEE_BINARY128) \ > || defined(_GLIBCXX_HAVE_FLOAT128_MATH)) > test_functions<std::float128_t>(); > #endif > diff --git > a/libstdc++-v3/testsuite/26_numerics/headers/cmath/functions_std_c++23.cc > b/libstdc++-v3/testsuite/26_numerics/headers/cmath/functions_std_c++23.cc > index ea68ac5da75..bf07493ecd4 100644 > --- a/libstdc++-v3/testsuite/26_numerics/headers/cmath/functions_std_c++23.cc > +++ b/libstdc++-v3/testsuite/26_numerics/headers/cmath/functions_std_c++23.cc > @@ -131,7 +131,7 @@ main() > } > #endif > #if defined(__STDCPP_FLOAT128_T__) \ > - && (defined(_GLIBCXX_DOUBLE_IS_IEEE_BINARY128) \ > + && (defined(_GLIBCXX_LDOUBLE_IS_IEEE_BINARY128) \ > || defined(_GLIBCXX_HAVE_FLOAT128_MATH)) > { > std::float128_t p[128] = {}; > diff --git > a/libstdc++-v3/testsuite/26_numerics/headers/cmath/nextafter_c++23.cc > b/libstdc++-v3/testsuite/26_numerics/headers/cmath/nextafter_c++23.cc > index 91767d22cc3..2d0f8017f4a 100644 > --- a/libstdc++-v3/testsuite/26_numerics/headers/cmath/nextafter_c++23.cc > +++ b/libstdc++-v3/testsuite/26_numerics/headers/cmath/nextafter_c++23.cc > @@ -117,7 +117,7 @@ main () > test <std::float64_t>(); > #endif > #if defined(__STDCPP_FLOAT128_T__) \ > - && (defined(_GLIBCXX_DOUBLE_IS_IEEE_BINARY128) \ > + && (defined(_GLIBCXX_LDOUBLE_IS_IEEE_BINARY128) \ > || defined(_GLIBCXX_HAVE_FLOAT128_MATH)) > test <std::float128_t>(); > #endif > -- > 2.47.0 >
