On Thu, 24 Oct 2024 at 10:32, Jonathan Wakely <jwakely....@gmail.com> wrote:
> > > On Thu, 24 Oct 2024, 09:19 Jakub Jelinek, <ja...@redhat.com> wrote: > >> Hi! >> >> Here is the non-gcc part of the previous patch, include/, libiberty/, >> libcpp/, libgcc/, libstdc++-v3/. >> >> Is there something that should be left out? >> > > > libstdc++-v3/src/c++17/fast_float/fast_float.h comes from an external > project. Please leave that out, and we can ask upstream to fix it. > Ironically, the line above in my previous email has trailing whitespace ;) These upstream commits already removed the trailing whitespace in the code: https://github.com/jwakely/fast_float/commit/e3fd438c64c973f38c7f4e89790052a67adeba9a https://github.com/fastfloat/fast_float/commit/39e04ea7668b191e748cd294a4942dabdd9ace12 I've submitted https://github.com/fastfloat/fast_float/pull/272 to stop adding it to the licence header. Next time Patrick syncs from upstream we should get rid of the trailing whitespace in that file. > > The other libstdc++ changes are OK, thanks for doing this. > > I don't know whether Doxygen treats two spaces at the end of a line as a > forced line-break, like Markdown does, but I checked that none of the > libstdc++ changes in the patch would be affected by that anyway. > > >
