On Wed, 23 Oct 2024 at 18:37, François Dumont <frs.dum...@gmail.com> wrote: > > Sorry but I'm not sure, is it also ok for the 3 backports ?
Yeah, I should have said - OK for the branches too, thanks. > > On 22/10/2024 22:43, Jonathan Wakely wrote: > > On Tue, 22 Oct 2024 at 18:28, François Dumont <frs.dum...@gmail.com> wrote: > >> Hi > >> > >> libstdc++: Always instantiate key_type to compute hash code > >> [PR115285] > >> > >> Even if it is possible to compute a hash code from the inserted > >> arguments > >> we need to instantiate the key_type to guaranty hash code > >> consistency. > >> > >> Preserve the lazy instantiation of the mapped_type in the context of > >> associative containers. > >> > >> libstdc++-v3/ChangeLog: > >> > >> PR libstdc++/115285 > >> * include/bits/hashtable.h (_S_forward_key<_Kt>): Always > >> return a temporary > >> key_type instance. > >> * testsuite/23_containers/unordered_map/96088.cc: Adapt to > >> additional instanciation. > >> Also check that mapped_type is not instantiated when there > >> is no insertion. > >> * testsuite/23_containers/unordered_multimap/96088.cc: > >> Adapt to additional > >> instanciation. > >> * testsuite/23_containers/unordered_multiset/96088.cc: > >> Likewise. > >> * testsuite/23_containers/unordered_set/96088.cc: Likewise. > >> * testsuite/23_containers/unordered_set/pr115285.cc: New > >> test case. > >> > >> > >> Tested under Linux x64, > >> > >> ok to commit ? > > OK, thanks > > >
