On Tue, Jul 10, 2012 at 12:40 AM, Maxim Kuvyrkov <ma...@codesourcery.com> wrote: > On 10/07/2012, at 8:51 AM, Igor Zamyatin wrote: > >> Let's try with this patch then. Is it ok for trunk after all >> appropriate testing is done? > > Sorry for the late reply, I've been down with a virus last week. > > Uros, > > Would you please approve this patch for i386 provided my review below? > >> >> ChangeLog: >> >> 2012-07-09 Sergey Melnikov <sergey.melni...@intel.com> >> >> * config/i386/i386.md (stack_protect_set): Disable the pattern >> for Android since Android libc (bionic) does not provide random >> value for stack protection guard at gs:0x14. Guard value >> will be provided from external symbol (default implementation). >> (stack_protect_set_<mode>): Likewise. >> (stack_protect_test): Likewise. >> (stack_protect_test_<mode>): Likewise.
This is OK. BTW: Since the patch touches only Android specific functionality (and doesn't affect generic functionality), your approval should be enough. Thanks, Uros.
