On Fri, Jul 6, 2012 at 8:29 AM, Steven Bosscher <stevenb....@gmail.com> wrote: > On Fri, Jul 6, 2012 at 1:06 AM, Joseph S. Myers <jos...@codesourcery.com> > wrote: >> My only comment is that you add a coretypes.h include to tree-flow.h and >> remove one from tree-ssa-alias.h - but since the GCC convention is that >> all .c files start with includes of config.h, system.h and coretypes.h in >> that order, the include in tree-flow.h shouldn't be needed - any source >> file including tree-flow.h should have included coretypes.h before >> tree-flow.h. (That is, I think any include of coretypes.h from another .h >> file, except probably for the special case of gcc-plugin.h, is suspect >> unless we decide to change the convention.) > > Agreed. I thought, too, that this is the convention, and was surprised > to find coretypes.h included in another header.
BTW, why do so many libgcc files include coretypes.h? As far as I can tell, only libgcc/config/tilepro/atomic.c actually uses types defined in coretypes.h (it uses memmodel and IMHO that'd be a bug). Ciao! Steven
