On Fri, Oct 11, 2024 at 02:55:38PM GMT, Joseph Myers wrote:
> On Fri, 11 Oct 2024, Alejandro Colomar wrote:
> 
> > That was insane.
> > 
> > Link: <https://software.codidact.com/posts/292718>
> > Signed-off-by: Alejandro Colomar <a...@kernel.org>
> > ---
> >  gcc/testsuite/gcc.c-torture/execute/pr68143_1.c | 2 +-
> >  gcc/testsuite/gcc.c-torture/execute/pr70566.c   | 2 +-
> >  gcc/testsuite/gcc.dg/tm/20100615.c              | 2 +-
> >  gcc/testsuite/gcc.target/aarch64/pr91927.c      | 2 +-
> 
> Testcases should not be modified for stylistic issues like this, only if 
> there are actual problems with the old code (and if there are, appropriate 
> consideration would need to be given to whether to change the code or just 
> the compilation options, to minimize the perturbation to whatever is being 
> tested).  (I agree with changing libiberty to avoid defining NULL as 0.)

Ok; I'll drop that part.  Thanks!

Have a lovely day!
Alex

> 
> -- 
> Joseph S. Myers
> josmy...@redhat.com
> 

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature

Reply via email to