On Tuesday, October 8th, 2024 at 11:21 AM, Marek Polacek <pola...@redhat.com> wrote:
> > > On Mon, Oct 07, 2024 at 11:16:20PM +0000, Ken Matsui wrote: > > > On Monday, October 7th, 2024 at 4:41 PM, Marek Polacek pola...@redhat.com > > wrote: > > > > > On Sat, Jun 15, 2024 at 10:30:35PM -0700, Ken Matsui wrote: > > > > > > > This patch adds a warning switch for "#pragma once in main file". The > > > > warning option name is Wpragma-once-outside-header, which is the same > > > > as Clang provides. > > > > > > I think the patch is OK now, thanks. Other diagnostics inlude the '#' > > > character but I know you just did what David suggested. > > > > Thank you for your review! It might be better to keep consistency between > > other compilers, but do we proceed with the current change? > > > I personally would have included that '#' but others may not > really care either way. I also personally prefer to have '#', so let me add it. Thank you. > > > Just to confirm, since you are a C front end reviewer, am I now ok to push > > this patch? > > > Yes, thanks. > > Marek
