On 5/23/24 3:55 AM, Di Zhao OS wrote:
-----Original Message-----
From: Jeff Law <jeffreya...@gmail.com>
Sent: Wednesday, May 22, 2024 11:14 PM
To: Di Zhao OS <diz...@os.amperecomputing.com>; gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [tree-optimization/110279] fix testcase pr110279-1.c
On 5/22/24 5:46 AM, Di Zhao OS wrote:
The test case is for targets that support FMA. Previously
the "target" selector is missed in dg-final command.
Tested on x86_64-pc-linux-gnu.
Thanks
Di Zhao
gcc/testsuite/ChangeLog:
* gcc.dg/pr110279-1.c: add target selector.
Rather than list targets explicitly in the test, wouldn't it be better
to have a common routine that could be used in other cases where we have
a test that requires FMA?
So something similar to check_effective_target_scalar_all_fma?
Jeff
Here is an updated version of the patch. Sorry I'm not very familiar
with the testsuite commands.
gcc/testsuite/ChangeLog:
* gcc.dg/pr110279-1.c: add target selector.
This is OK. Thanks for your patience. SOrry it's taken so long. Just
never seemed to get near the top of my todo list.
Ideally we'll see maintainers adjust the scalar_all_fma selector and if
we see other targets that have some fma, but not the full set, then
we'll see a new target selector for the subsets of fma.
jeff
