On 8/30/24 8:49 AM, Nina Dinka Ranns wrote:
We currently do not expect comdat group of the guarded function to
be set at the time of generating pre and post check function.
However, in the case of an explicit instantiation, the guarded
function has been added to a comdat group before generating contract
check functions, which causes the observed ICE. Current assert
removed and an additional check for comdat group of the guarded
function added. With this change, the pre and post check functions
get added to the same comdat group of the guarded function if the
guarded function is already placed in a comdat group.
Tested on x86_64-pc-linux-gnu.
Patch attached to the email.
Thanks for the ping, I missed this the first time. Please CC me
directly on C++ patches, especially on pings.
FWIW it attached as application/x-patch, which Thunderbird doesn't
understand to display inline; text/plain or text/x-patch attachments
work better. I don't know how to tell gmail that it's text other than
perhaps changing the extension to .txt.
Please include the ChangeLog entries in plaintext, along with the
description/rationale.
Pushed, thanks!
Jason
