On 9/21/24 22:52, Jakub Jelinek wrote:
On Sat, Sep 21, 2024 at 08:08:29PM -0600, Sandra Loosemore wrote:
On 9/20/24 01:41, Jakub Jelinek wrote:
+
+ /* Check for unknown properties. */
if (omp_ts_map[ts_code].valid_properties == NULL)
continue;
-
Why?
Why what? I made this change because when I added another check in this
loop I was temporarily confused about the control flow and I thought this
would help. If you're asking why it's doing the null check here, it's
because it doesn't make sense to check properties on all selectors, like
properties that can have implementation-defined values for other compilers.
I meant why the empty line was removed?
To make it more clear that the null check is part of the code chunk to
diagnose unknown properties -- each of which is now formatted the same
way, with a blank line, comment to explain what it's doing, and no blank
lines within the chunk.
-Sandra
