On Wed, Sep 18, 2024 at 1:40 PM Haochen Jiang <haochen.ji...@intel.com> wrote: > > Hi all, > > Since commit r15-3594, we fixed the bugs in MASK_TYPE for AVX10.2 > testcases, but we missed the following four. > > The tests are not FAIL since the binutils part haven't been merged > yet, which leads to UNSUPPORTED test. But the avx512f-mask-type.h > needs to be included, otherwise, it will be compile error. > > Tested with asseblmer having those insts and sde. Ok for trunk? Ok. > > Thx, > Haochen > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/avx10_2-512-vpdpbssd-2.c: Include > avx512f-mask-type.h. > * gcc.target/i386/avx10_2-vminmaxsd-2.c: Ditto. > * gcc.target/i386/avx10_2-vminmaxsh-2.c: Ditto. > * gcc.target/i386/avx10_2-vminmaxss-2.c: Ditto. > --- > gcc/testsuite/gcc.target/i386/avx10_2-512-vpdpbssd-2.c | 2 ++ > gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsd-2.c | 1 + > gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsh-2.c | 1 + > gcc/testsuite/gcc.target/i386/avx10_2-vminmaxss-2.c | 1 + > 4 files changed, 5 insertions(+) > > diff --git a/gcc/testsuite/gcc.target/i386/avx10_2-512-vpdpbssd-2.c > b/gcc/testsuite/gcc.target/i386/avx10_2-512-vpdpbssd-2.c > index add9de89351..624a1a8e50e 100644 > --- a/gcc/testsuite/gcc.target/i386/avx10_2-512-vpdpbssd-2.c > +++ b/gcc/testsuite/gcc.target/i386/avx10_2-512-vpdpbssd-2.c > @@ -13,6 +13,8 @@ > #define SRC_SIZE (AVX512F_LEN / 8) > #define SIZE (AVX512F_LEN / 32) > > +#include "avx512f-mask-type.h" > + > static void > CALC (int *r, int *dst, char *s1, char *s2) > { > diff --git a/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsd-2.c > b/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsd-2.c > index 1e2d78c4068..f550e09be6c 100644 > --- a/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsd-2.c > +++ b/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsd-2.c > @@ -8,6 +8,7 @@ > #include "avx10-helper.h" > #include <stdbool.h> > #include "avx10-minmax-helper.h" > +#include "avx512f-mask-type.h" > > void static > CALC (double *r, double *s1, double *s2, int R) > diff --git a/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsh-2.c > b/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsh-2.c > index e6a93c403b5..dbf1087d9c3 100644 > --- a/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsh-2.c > +++ b/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxsh-2.c > @@ -8,6 +8,7 @@ > #include "avx10-helper.h" > #include <stdbool.h> > #include "avx10-minmax-helper.h" > +#include "avx512f-mask-type.h" > > void static > CALC (_Float16 *r, _Float16 *s1, _Float16 *s2, int R) > diff --git a/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxss-2.c > b/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxss-2.c > index 47177e69640..7baa396a2d3 100644 > --- a/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxss-2.c > +++ b/gcc/testsuite/gcc.target/i386/avx10_2-vminmaxss-2.c > @@ -8,6 +8,7 @@ > #include "avx10-helper.h" > #include <stdbool.h> > #include "avx10-minmax-helper.h" > +#include "avx512f-mask-type.h" > > void static > CALC (float *r, float *s1, float *s2, int R) > -- > 2.31.1 >
-- BR, Hongtao