<saurabh....@arm.com> writes:
> @@ -3082,6 +3084,8 @@
> (define_int_iterator SVE_COND_ICVTF [UNSPEC_COND_SCVTF UNSPEC_COND_UCVTF])
>
> (define_int_iterator SVE_COND_FP_BINARY [UNSPEC_COND_FADD
> + (UNSPEC_COND_FAMAX
> "TARGET_SVE_FAMINMAX")
> + (UNSPEC_COND_FAMIN
> "TARGET_SVE_FAMINMAX")
> UNSPEC_COND_FDIV
> UNSPEC_COND_FMAX
> UNSPEC_COND_FMAXNM
Sorry for the trivia, but now that the lines exceed 80 characters,
could you reformat the whole define_int_iterator into the same style
as SVE_BFLOAT_TERNARY_LONG, with the "[" on a separate line, indented
by two spaces? Similarly later.
> diff --git a/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
> b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
> new file mode 100644
> index 00000000000..2646f29e60c
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
> @@ -0,0 +1,155 @@
> +/* { dg-additional-options "-O3 -march=armv9-a+sve+faminmax" } */
> +/* { dg-final { check-function-bodies "**" "" "-DCHECK_ASM" } } */
For all the tests, could you add:
#pragma GCC target "+faminmax"
instead of using an -march line?
These tests are run with multiple options, so we also shouldn't use -O3
(or dg-options generally).
Looks good otherwise, and other than the stray file that Kyrill mentioned.
Thanks,
Richard
