On Thu, 12 Sep 2024, Jakub Jelinek wrote:
> On Wed, Sep 11, 2024 at 10:23:20PM +0000, Joseph Myers wrote:
> > On Fri, 30 Aug 2024, Jakub Jelinek wrote:
> >
> > > +should be no newlines in the string literal and because this parameter
> > > +is meant namely for use by the preprocessor itself, there is no support
> > > +for any escape sequences in the string literal argument. If
> > > @code{gnu::base64}
> >
> > Given the "no escape sequences" rule, I think there should be a test for
> > that - testing rejection of a string that would be valid if escape
> > sequences were processed (for example, valid base64 but with the
> > individual characters encoded using \x), but is not valid because they are
> > not processed. As far as I can see, the existing tests with escape
> > sequences are invalid for other reasons (they use \n as the escape
> > sequence).
>
> Thanks.
>
> Here is an updated patch and before that just the incremental diff from
> the previous patch.
This version is OK.
--
Joseph S. Myers
josmy...@redhat.com
