Jason Merrill <ja...@redhat.com> writes: >> This is the new output - the diagnostics no longer expand that macro, >> since the location is not wholly contained within it. The relevant part >> of the diagnostics after the change is: >> --8<---------------cut here---------------start------------->8--- >> | >> 'const char* inner(int)': event 5 (depth 3) >> | >> | return NULL; >> | >> --8<---------------cut here---------------end--------------->8--- >> ... as opposed to (excuse the quote difference - the former was pulled >> from g++.log and the latter from a manual invocation): >> --8<---------------cut here---------------start------------->8--- >> | >> ‘const char* inner(int)’: event 5 (depth 3) >> | >> >> |/home/arsen/gcc-mine/gcc/testsuite/c-c++-common/analyzer/../../gcc.dg/analyzer/analyzer-decls.h:7:14: >> | #define NULL nullptr >> | ^~~~~~~ >> | | >> | (5) ...to here >> /home/arsen/gcc-mine/gcc/testsuite/c-c++-common/analyzer/inlining-4-multiline.c:14:12: >> note: in expansion of macro ‘NULL’ >> | return NULL; >> | ^~~~ >> | >> --8<---------------cut here---------------end--------------->8--- >> ... presumably, the diagnostics chose to elide those bits of output due >> to the new location covering the entire line (and hence not being too >> informative) - but I haven't debugged that (as I assumed the diagnostic >> code is DTRT now). > > It seems weird to lose the "...to here" marking on the return. Any thoughts, > David?
Gentle ping on this patch/question. TIA, have a lovely night. -- Arsen Arsenović
signature.asc
Description: PGP signature
