On Fri, 30 Aug 2024, Jakub Jelinek wrote:
> On Fri, Aug 16, 2024 at 04:58:58PM +0000, Joseph Myers wrote:
> > On Thu, 15 Aug 2024, Jakub Jelinek wrote:
> >
> > > + else
> > > + {
> > > + if (res > INTTYPE_MAXIMUM (off_t))
> > > + cpp_error_with_line (pfile, CPP_DL_ERROR, loc, 0,
> > > + "too large 'gnu::offset' argument");
> >
> > Having a testcase for this diagnostic would be a good idea. Also one for
> > a negative argument for gnu::offset (the errors for negative arguments are
> > already tested for limit, but I think testing that for gnu::offset is a
> > good idea as well).
>
> Here is an updated patch which does that:
This patch is OK.
--
Joseph S. Myers
josmy...@redhat.com
