On Thu, Sep 5, 2024 at 2:52 PM Jeff Law <jeffreya...@gmail.com> wrote: > > > > On 9/5/24 12:52 PM, Palmer Dabbelt wrote: > > We have cheap logical ops, so let's just move this back to the default > > to take advantage of the standard branch/op hueristics. > > > > gcc/ChangeLog: > > > > PR target/116615 > > * config/riscv/riscv.h (LOGICAL_OP_NON_SHORT_CIRCUIT): Remove. > > --- > > There's a bunch more discussion in the bug, but it's starting to smell > > like this was just a holdover from MIPS (where maybe it also shouldn't > > be set). I haven't tested this, but I figured I'd send the patch to get > > a little more visibility. > > > > I guess we should also kick off something like a SPEC run to make sure > > there's no regressions? > Yea, I'd definitely want to see some hard data on an implementation for > this. I wouldn't want to rely just on icounts and eyeballing given its > dependent on branch predictor accuracy and such. BPI is probably the > best platform for this kind of testing right now. > > I probably can't spin it this week, but probably could next week.
Thanks. If you don't mind, please also collect the static code-size statistics so we can decide if we need to choose different strategies when optimizing for size vs. speed. > > jeff >
