Thanks Jeff. Yes, sounds good to me.
Mark
On 27/08/2024 16:23, Jeff Law wrote:
On 8/26/24 4:48 PM, Mark Harmstone wrote:
Run all CodeView names through a new function get_name, which chains
together a DIE's DW_AT_name with that of its parent to create a
C++-style name.
gcc/
* dwarf2codeview.cc (get_name): New function.
(add_enum_forward_def): Call get_name.
(get_type_num_enumeration_type): Call get_name.
(add_struct_forward_def): Call get_name.
(get_type_num_struct): Call get_name.
(add_variable): Call get_name.
(add function): Call get_name.
* dwarf2out.cc (get_die_parent): Rename to dw_get_die_parent and make
non-static.
(generate_type_signature): Handle renamed get_die_parent.
* dwarf2out.h (dw_get_die_parent): Add declaration.
This series is fine.
I don't think I'm really adding much with the review step. You're the expert
here, so with your permission I'd like to ask the steering committee to ACK you
as maintainer of the codeview bits.
Jeff
