On Mon, 26 Aug 2024 at 00:08, Andrew Pinski <pins...@gmail.com> wrote: > > On Fri, Aug 23, 2024 at 5:20 AM Jonathan Wakely <jwak...@redhat.com> wrote: > > > > Tested x86_64-linux. Pushed to trunk. > > > > -- >8 -- > > > > The standard says this constructor should be private. LWG 4141 proposes > > to remove it entirely. We still need it, but it doesn't need to be > > public. > > > > For std::bitset the default constructor is already private (and never > > even defined) but there's a non-standard constructor that's public, but > > doesn't need to be. > > This looks like broke the pretty-printers testcase: > ``` > /home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/simple.cc: > In function 'int main()': > /home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/simple.cc:156: > error: 'std::_Bit_reference::_Bit_reference()' is private within this > context > In file included from > /home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/include/vector:67, > from > /home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/simple.cc:31: > /home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/stl_bvector.h:90: > note: declared private here > compiler exited with status 1 > > ... > spawn -ignore SIGHUP > /home/apinski/src/upstream-gcc-isel/gcc/objdir/./gcc/xg++ > -shared-libgcc -B/home/apinski/src/upstream-gcc-isel/gcc/objdir/./gcc > -nostdinc++ > -L/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/src > -L/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/src/.libs > -L/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs > -B/home/apinski/upstream-gcc-isel/x86_64-pc-linux-gnu/bin/ > -B/home/apinski/upstream-gcc-isel/x86_64-pc-linux-gnu/lib/ -isystem > /home/apinski/upstream-gcc-isel/x86_64-pc-linux-gnu/include -isystem > /home/apinski/upstream-gcc-isel/x86_64-pc-linux-gnu/sys-include > -fchecking=1 > -B/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/./libstdc++-v3/src/.libs > -fmessage-length=0 -fno-show-column -ffunction-sections > -fdata-sections -fcf-protection -mshstk -g -O2 -D_GNU_SOURCE > -DLOCALEDIR="." -nostdinc++ > -I/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu > -I/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/include > -I/home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/libsupc++ > -I/home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/include/backward > -I/home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/util > /home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/simple11.cc > -g -O0 -fdiagnostics-plain-output ./libtestc++.a -Wl,--gc-sections > -L/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/src/filesystem/.libs > -L/home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/src/experimental/.libs > -lm -o ./simple11.exe > /home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/simple11.cc: > In function 'int main()': > /home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/simple11.cc:149: > error: 'std::_Bit_reference::_Bit_reference()' is private within this > context > In file included from > /home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/include/vector:67, > from > /home/apinski/src/upstream-gcc-isel/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/simple11.cc:31: > /home/apinski/src/upstream-gcc-isel/gcc/objdir/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/stl_bvector.h:90: > note: declared private here > compiler exited with status 1 > ``` > > Noticed because of the new UNRESOLVED .
Oops, thanks for noticing. I didn't see it because it didn't add a FAIL. I'll push a fix to the tests.
