On 8/26/24 10:33 AM, Iain Sandoe wrote:
As the PR notes, we now have two bogus warnings that the single frame
pointer parameter is unused in each of the helper functions.
This started when we began to use start_preparsed_function/finish_function
to wrap the helper function code generation. I am puzzled a little about
why the use is not evident without marking - or perhaps it is always needed
to mark use in synthetic code?
For the destroy function, in particular, the use of the parameter is simple
- an indirect ref and then it is passed to the call to the actor.
The fix here is somewhat trivial - to mark the param as used as soon as it
is.
You also wouldn't get the warning if the param were marked
DECL_ARTIFICIAL, which seems desirable anyway?
Jason
