On 8/23/24 10:36 AM, Iain Sandoe wrote:
Hi Jason,

+      tree iarc_m = lookup_member (frame_type, coro_frame_i_a_r_c_id,
+                                  1, 0, tf_warning_or_error);
+      tree iarc_x = build_class_member_access_expr (deref_fp, iarc_m, 
NULL_TREE,
+                                                  false, tf_warning_or_error);

Do you need to call lookup_member directly?  I'd think you could just pass the 
identifier to build_class_member_access_expr.  And in several other places in 
coroutine.cc, as well.

AFAICT, I do... the doc for build_class_member_access_expr () says:
  "MEMBER is a DECL or baselink.".  We could extend the API to allow a member
identifier (which would be nice).  Maybe I'm missing something else?

Ah, I was confusing it with /finish/_class_member_access_expr, which can take an identifier. Would it work to use that instead of build_?

In the meantime, this patch is OK.

Jason

Reply via email to