On Wed, 7 Aug 2024 at 08:09, Filip Kastl <fka...@suse.cz> wrote: > > On Tue 2024-08-06 17:00:24, Gerald Pfeifer wrote: > > > +<p> > > > +The following headers are used less widely in libstdc++ and may need to
I like Gerald's suggestion to change this to "within libstdc++" as that is more precise about that change. > > > +be included explicitly when compiling with GCC 15: > > > +<ul> > > > +<li> <code><cstdint></code> > > > + (for <code>std::int8_t</code>, <code>std::int32_t</code> etc.) > > > +</li> > > > > The text reads "headers", alas there only appears to be one right now? > > So "header is" (singular)? > > Nice catch. I didn't notice this plural/singular mismatch. Hmm, I could do > this: > > <p>Some C++ Standard Library headers have been changed to no longer include > other headers that were being used internally by the library. > As such, C++ programs that used standard library components without > including the right headers will no longer compile. > </p> > <p> > In particular, the following header is used less widely in libstdc++ and may > need to be included explicitly when compiling with GCC 15: > </p> > <ul> > <li> <code><cstdint></code> > (for <code>std::int8_t</code>, <code>std::int32_t</code> etc.) > </li> > </ul> > > Here I only change the second paragraph. The logic behind this is that the > first paragraph introduces the problem, therefore speaks more generally and > uses plural. Then the second paragraph speaks about the particular header in > question and uses singular. > > Or I could do this: > > <p>Some C++ Standard Library headers have been changed to no longer include > the > <code><cstdint></code>/<code><stdint.h></code> header that was > being used internally by the library. As such, C++ programs that used standard > library components without including <code><cstdint></code> where needed > will no longer compile. > </p> > > <!-- Switch to this formulation if there are more headers like this > <p>Some C++ Standard Library headers have been changed to no longer include > other headers that were being used internally by the library. > As such, C++ programs that used standard library components without > including the right headers will no longer compile. > </p> > <p> > The following headers are used less widely in libstdc++ and may need to > be included explicitly when compiling with GCC 15: > <ul> > <li> <code><cstdint></code> > (for <code>std::int8_t</code>, <code>std::int32_t</code> etc.) > </li> > --> > > Any opinion on these two options? There might be more changes for GCC 15 that require additions here, so I'd suggest the first form, as it's simpler to just add a new <li> for other headers, rather than rewrite the paragraph that talks about cstdint inline.