On 8/9/24 10:42, Jakub Jelinek wrote:
Why needs omp-general.h the move in GTFILES etc.? Will just moving those definitions be ok?
I just double-checked that. The Makefile.in change to reorder omp-general.h in GTFILES is because of moving the definition of score_wide_int there from omp-general.cc. Otherwise the gtype processing seems to be confused by getting the two files in the wrong order:
/path/to/gcc/omp-general.h:96: type `score_wide_int' previously defined /path/to/gcc/omp-general.cc:2436: previously defined here make[3]: *** [Makefile:2979: s-gtype] Error 1 I'll add a note to the changelog line for that to explain what it's for.
Otherwise LGTM.
Thanks for the review! -Sandra
