> Date: Wed, 14 Aug 2024 20:58:04 -0500 > From: Jacob Bachmeyer <jcb62...@gmail.com> > Reply-To: jcb62...@gmail.com
> Hans-Peter Nilsson wrote: > > (CC to the dejagnu project as a heads-up) > > > > Regtested cris-elf with a fresh newlib checkout where 2640 > > libstdc++-v3 tests otherwise fail due to the stubbed newlib > > _getentropy. Ok to commit? > > > > -- >8 -- > > Newer newlib trigger warnings about certain functions not implemented > > (_getentropy) when testing libstdc++-v3. > > > > Since 2018 (circa binutils-2.10) the "in function" prefix isn't > > capitalized for those "not implemented" warnings when generated from > > the linker (a GNU ld feature used by newlib). Dejagnu up to and > > including at least dejagnu-1.6.3 (and git @ 42979bd3b9) assumes a > > capital "In function", leaving that part unpruned, and boom we have > > thousands of "excess errors" from the libstdc++-v3 testsuite. > > > > To confirm: newer binutils drops capitalization in a message "in > function FOO\nBAR is not implemented and will always fail". DejaGnu > expects GNU ld to say "In function FOO..." and fails to recognize the > new form. Correctly understood. I see I managed to goof the version corresponding to the binutils commit (the "git tag --contains df5f2391f7b2e"). To wit, the first release containing the miniscule "in function" seems to be not binutils-2.10 but binutils-2.31 (modulo back-ports that I didn't check). > If this is correct, I will fix it in Git master. (The fix is trivial: > change the "I" to "[Ii]" to accept both forms.) Yes, thanks; just don't forget to escape the []. :) > (You may still want to add the patch to the testsuite, for compatibility > with older versions of DejaGnu.) Definitely; gcc development doesn't require top-of-the-tree tools. brgds, H-P
