On 8/14/24 13:24, Tamar Christina wrote:
It seems to me that this should take a code_helper, create the vector modes and call directly_supported_p, or am I missing something?
Ok. Having done some digging around in the git history, I see that `vect_supportable_direct_optab_p', upon which I based my implementation of `vect_supportable_conv_optab_p', was committed before you wrote the `directly_supported_p' function, which I guess explains why `vect_supportable_direct_optab_p' does not take advantage of the latter function to avoid code duplication.
I'd wrongly presumed that we'd have been aware of the existence of `directly_supported_p' when writing `vect_supportable_direct_optab_p', such that any apparent code duplication would have been a conscious choice by the author, thus making it a relevant design consideration in my own implementation.
Anyway, will submit updated patch shortly. Cheers, Victor
