Re: [PATCH] ifcvt: Fix force_operand ICE due to noce_convert_multiple_sets [PR116353]

[Sam James]

Manolis Tsamis <manolis.tsa...@vrull.eu> writes:

> Now that more operations are allowed for noce_convert_multiple_sets, we need 
> to
> check noce_can_force_operand on the sequence before calling 
> try_emit_cmove_seq.
> Otherwise an inappropriate argument may be given to copy_to_mode_reg and 
> result
> in an ICE.
>
> Fix-up for the recent ifcvt commit 72c9b5f438f22cca493b4e2a8a2a31ff61bf1477

Thanks! Bootstrapped & tested with all FEs with no regressions on amd64.

>
>       PR tree-optimization/116353
>
> gcc/ChangeLog:
>
>       * ifcvt.cc (bb_ok_for_noce_convert_multiple_sets): Check
>       noce_can_force_operand.
>
> gcc/testsuite/ChangeLog:
>
>       * gcc.target/i386/pr116353.c: New test.
>
> Tested-by: Christoph Müllner <christoph.muell...@vrull.eu>
> Signed-off-by: Manolis Tsamis <manolis.tsa...@vrull.eu>
> ---

sam

signature.asc
Description: PGP signature