Hello,

Le 06/08/2024 à 22:57, Thomas Koenig a écrit :
Hi Mikael and Harald,

- inline expansion is inhibited at -Os.  But wouldn't it be good if
   we make this expansion also dependent on -ffrontend-optimize?
   (This was the case for rank-1 before your patch).

By the way, I disabled the minmaxloc frontend optimization without too much thought, because it was preventing me from seeing the effects of my patches in the dumps. Now that both of you have put some focus on it, I think the optimization should be completely removed instead, because the patches make it unreachable.

The original idea was to have -ffrontend-optimize as a check if anything
went wrong with front-end optimization in particular - if the bug went
away with -fno-frontend-optimize, we knew where to look (and I knew
I had to look).

It also provides a way for users to workaround bugs in frontend optimizations. If inline expansion were dependent on the flag, it would also provide the same benefit, but it would be using the flag outside of its intended scope, so I would rather not do it.

So, probably better to not do this at -Os.  One thought: Should we
also do the inlining without optimization?

At -Os: no inline expansion.  Don't we all agree on that?
I'm fine with also disabling expansion at -O0.

Mikael

Reply via email to