On Wed, Aug 7, 2024 at 9:42 AM Jakub Jelinek <ja...@redhat.com> wrote: > > On Wed, Aug 07, 2024 at 09:40:06AM +0200, Richard Biener wrote: > > On Tue, Aug 6, 2024 at 11:29 PM Andrew Pinski <quic_apin...@quicinc.com> > > wrote: > > > > > > This is a small cleanup with respect to the ranger_op_table class. > > > There should only ever be one instance of ranger_op_table so > > > this adds a static member function which returns the instance. > > > A few variables that are defined in range-op.cc should be local > > > to the file so wrap them with an anonymous namespace. > > > Also change operator_table into a reference that is initialized to > > > the singelton. > > > > > > This has a small extra overhead at intiialization time of the > > > operator_table; > > > could be improved if we used C++20's consteval. Since this happens only > > > once, > > > there it should be ok. > > > > Can you make it so with appropriate #if __cplusplus or __has_feature > > (consteval) > > (or how that's done)? > > That would be > #if __cpp_consteval >= 201811L > unless you need the P2564R3 paper behavior (then it would be > #if __cpp_consteval >= 202211L > ).
Thanks - IMO it's worth optimizing static initialization. Richard. > > Jakub >
