On Wed, Aug 7, 2024 at 8:57 AM Sam James <s...@gentoo.org> wrote: > > Philipp Tomsich <philipp.toms...@vrull.eu> writes: > > Hi, > > > Sam, Jakub & Robin, > > > > We had an "OK for trunk" from Jeff for v4 (see > > https://gcc.gnu.org/pipermail/gcc-patches/2024-July/656907.html) and > > it has been two more weeks for this RESEND. > > I'll push this by end of this week unless I hear otherwise. > > I'd ping Jeff for a quick re-review of v5 to make sure he's happy with > the changes to address > https://gcc.gnu.org/pipermail/gcc-patches/2024-July/656908.html. > To answer Jeff's question, although that patch removes the checks for particular SRC codes, it adds noce_operand_ok (src) which checks side_effects_p (src) and may_trap_p (src). This handles the asm related things and is in line with what the rest of ifcvt does, so there was no change needed for that comment.
> I can't comment on ifcvt changes to say if they're OK or not otherwise, > sorry. > > > > > Thanks, > > Philipp. > > > > > > On Fri, 26 Jul 2024 at 12:50, Sam James <s...@gentoo.org> wrote: > >> > >> Manolis Tsamis <manolis.tsa...@vrull.eu> writes: > >> > >> > This is an extension of what was done in PR106590. > >> > >> FWIW, I think that if a bug is worth mentioning in the commit message, > >> it's worth tagging so the hooks pick it up (as you get a nice > >> reverse-mapping then if anyone is looking at it and wondering if a > >> follow-up occurred). > >> > >> CC'd Jakub too given he wrote that commit and maybe he wants to review. > >> > >> Fixed Robin's email in CC list too. > >> > >> > [...] > >> > >> thanks, > >> sam
