On Mon, May 27, 2024 at 10:36:17AM +0530, Tejas Belagod wrote:
> This patch tests various shared clauses with SVE types. It also adds a test
> scaffold to run OpenMP tests in under the gcc.target testsuite.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/sve/omp/aarch64-sve-omp.exp: New scaffold.
> * gcc/testsuite/gcc.target/aarch64/sve/omp/shared.c: New test.
I'd suggest gcc.target/aarch64/sve/gomp/gomp.exp
E.g. when doing quick testing of OpenMP patches, I'm just doing
make check-gcc RUNTESTFLAGS='gomp.exp goacc.exp goacc-gomp.exp'
+ libgomp testing, I think it would be useful not to have to remember
other *.exp names. And gomp instead of omp as directory name would be
also consistent what is used elsewhere, gcc.dg/gomp/, g++.dg/gomp/,
gfortran.dg/gomp/, c-c++-common/gomp/ etc.
Though, for the driver name, on the other side gomp.exp doesn't add the
libgomp/.libs/ directory to search path etc., runtime tests generally
go to libgomp.
So, maybe this would better go into
libgomp/testsuite/libgomp.target/aarch64/aarch64.exp
Jakub
