On 8/1/24 12:48 PM, Arsen Arsenović wrote:
Tested on x86_64-pc-linux-gnu, no regression.

OK for trunk?

TIA, have a lovely day.
---------- >8 ----------
Previously, we were building and inserting case_labels manually, which
lead to them not being added into the currently running switch via

"led"

c_add_case_label.  This lead to false diagnostics that the user could
not act on.

The case changes are OK.

The use of temp_override on current_function_decl is a temporary hack,

We can do better than this.

as we intend to factor out generating the outlined functions (including
the actor) to happen later in finish_function, when we can create a new
function using the standard routines for that, similar to
finish_function_contracts.

If you want to do that, sure, but it doesn't seem necessary; it's quite common to push into defining a function in the middle of defining another one. In maybe_add_lambda_conv_op, for instance: basically just push_function_context before start_preparsed_function.

Jason

Reply via email to