On Mon, 29 Jul 2024 at 21:58, Giuseppe D'Angelo wrote: > > Hi, > > And this is the corresponding change libstdc++.
Thanks for the patch. Do you have a copyright assignment for GCC in place, or are you covered by a corporate assignment for KDAB? If not, please complete that process, or contribute under the DCO terms, see https://gcc.gnu.org/contribute.html#legal This is a C++26 change, so it can use bool_constant instead of __bool_constant. That's only needed for C++11 and C++14 code. The new test says: +// Copyright (C) 2013-2024 Free Software Foundation, Inc. Unless you reused the code from an existing test that was written in 2013, then the date is wrong. And if you dont' have a copyright assignment, then claiming it's copyright FSF is also wrong. Please don't put copyright and license headers on new tests at all, unless they really are copyright FSF, and really do contain something original and copyrightable (which I don't think applies here). This is documented at https://gcc.gnu.org/onlinedocs/libstdc++/manual/test.html#test.new_tests With those things fixed, this should definitely go in once the new built-in is supported in the compiler, thanks again!
