> -----Original Message----- > From: Jakub Jelinek <ja...@redhat.com> > Sent: Friday, July 26, 2024 2:31 PM > To: Jiang, Haochen <haochen.ji...@intel.com> > Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao <hongtao....@intel.com>; > ubiz...@gmail.com > Subject: Re: [PATCH] i386: Fix AVX512 intrin macro typo > > On Fri, Jul 26, 2024 at 02:25:22PM +0800, Haochen Jiang wrote: > > Hi all, > > > > There are several typo in AVX512 intrins macro define. They will > > eventually result in errors with -O0. This patch will fix that. > > Add a testcase that verifies that?
Ok, I will add testcases with -O0 for them. Thx, Haochen > > > Bootstrapped on x86-64-pc-linux-gnu. Ok for trunk and backport to > > GCC14, GCC 13 and GCC 12? > > > > Thx, > > Haochen > > > > gcc/ChangeLog: > > > > * config/i386/avx512dqintrin.h > > (_mm_mask_fpclass_ss_mask): Correct operand order. > > (_mm_mask_fpclass_sd_mask): Ditto. > > (_mm_reduce_round_sd): Use -1 as mask since it is non-mask. > > (_mm_reduce_round_ss): Ditto. > > * config/i386/avx512vlbwintrin.h > > (_mm256_mask_alignr_epi8): Correct operand usage. > > (_mm_mask_alignr_epi8): Ditto. > > * config/i386/avx512vlintrin.h (_mm_mask_alignr_epi64): Ditto. > > Jakub