On Thu, Jul 25, 2024 at 12:01 PM Adhemerval Zanella Netto <adhemerval.zane...@linaro.org> wrote: > > > > On 17/07/24 14:00, Andrew Pinski wrote: > > On Wed, Jul 17, 2024 at 5:24 AM Richard Biener > > <richard.guent...@gmail.com> wrote: > >> > >> On Tue, Jul 16, 2024 at 3:36 PM Eikansh Gupta <quic_eikag...@quicinc.com> > >> wrote: > >>> > >>> This patch adds match pattern for `(a ? x : y) eq/ne (b ? x : y)`. > >>> In forwprop1 pass, depending on the type of `a` and `b`, GCC produces > >>> `vec_cond` or `cond_expr`. Based on the observation that `(x != y)` is > >>> TRUE, the pattern can be optimized to produce `(a^b ? TRUE : FALSE)`. > >>> > >>> The patch adds match pattern for a, b: > >>> (a ? x : y) != (b ? x : y) --> (a^b) ? TRUE : FALSE > >>> (a ? x : y) == (b ? x : y) --> (a^b) ? FALSE : TRUE > >>> (a ? x : y) != (b ? y : x) --> (a^b) ? TRUE : FALSE > >>> (a ? x : y) == (b ? y : x) --> (a^b) ? FALSE : TRUE > >> > >> OK. > > > > Pushed as r15-2106-g44fcc1ca11e7ea (with one small change to the > > commit message in the changelog where tabs should be used before the > > *; most likely a copy and paste error). > > It seems that this change triggered with Linaro CI on arm 32 bit [1]: > > -- > Executing on host: > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/destdir/x86_64-pc-linux-gnu/bin/arm-eabi-g++ > > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/g++.dg/tree-ssa/pr111150.C > -mthumb -march=armv8.1-m.main+mve.fp+fp.dp -mtune=cortex-m55 > -mfloat-abi=hard -mfpu=auto -fdiagnostics-plain-output -nostdinc++ > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/arm-eabi/gcc-gcc.git~master-stage2/arm-eabi/libstdc++-v3/include/arm-eabi > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/arm-eabi/gcc-gcc.git~master-stage2/arm-eabi/libstdc++-v3/include > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libstdc++-v3/libsupc++ > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libstdc++-v3/include/backward > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libstdc++-v3/testsuite/util > -fmessage-length=0 -std=gnu++98 -O1 -fdump-tree-forwprop1 -Wno-psabi -S > -o pr111150.s (timeout = 600) > spawn -ignore SIGHUP > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/destdir/x86_64-pc-linux-gnu/bin/arm-eabi-g++ > > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/g++.dg/tree-ssa/pr111150.C > -mthumb -march=armv8.1-m.main+mve.fp+fp.dp -mtune=cortex-m55 > -mfloat-abi=hard -mfpu=auto -fdiagnostics-plain-output -nostdinc++ > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/arm-eabi/gcc-gcc.git~master-stage2/arm-eabi/libstdc++-v3/include/arm-eabi > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/builds/x86_64-pc-linux-gnu/arm-eabi/gcc-gcc.git~master-stage2/arm-eabi/libstdc++-v3/include > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libstdc++-v3/libsupc++ > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libstdc++-v3/include/backward > > -I/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/libstdc++-v3/testsuite/util > -fmessage-length=0 -std=gnu++98 -O1 -fdump-tree-forwprop1 -Wno-psabi -S -o > pr111150.s > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/g++.dg/tree-ssa/pr111150.C: > In function 'v4si f1_(v4si, v4si, v4si, v4si, v4si, v4si)': > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/g++.dg/tree-ssa/pr111150.C:13:1: > error: unrecognizable insn: > (insn 22 21 26 2 (set (reg:V4SI 120 [ <retval> ]) > (unspec:V4SI [ > (reg:V4SI 136) > (reg:V4SI 137) > (subreg:V4BI (reg:HI 135) 0) > ] VPSELQ_S)) > "/home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/g++.dg/tree-ssa/pr111150.C":12:17 > -1 > (nil)) > during RTL pass: vregs > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/g++.dg/tree-ssa/pr111150.C:13:1: > internal compiler error: in extract_insn, at recog.cc:2848 > 0x21fd635 internal_error(char const*, ...) > ../../../../../../gcc/gcc/diagnostic-global-context.cc:491 > 0x9a0958 fancy_abort(char const*, int, char const*) > ../../../../../../gcc/gcc/diagnostic.cc:1725 > 0x840e4d _fatal_insn(char const*, rtx_def const*, char const*, int, char > const*) > ../../../../../../gcc/gcc/rtl-error.cc:108 > 0x840e6f _fatal_insn_not_found(rtx_def const*, char const*, int, char const*) > ../../../../../../gcc/gcc/rtl-error.cc:116 > 0x83f76b extract_insn(rtx_insn*) > ../../../../../../gcc/gcc/recog.cc:2848 > 0xf1a805 instantiate_virtual_regs_in_insn > ../../../../../../gcc/gcc/function.cc:1612 > 0xf1a805 instantiate_virtual_regs > ../../../../../../gcc/gcc/function.cc:1995 > 0xf1a805 execute > ../../../../../../gcc/gcc/function.cc:2042 > -- > > Should I open a bug report?
This is backend bug that was exposed by the patch. `vcond_mask_<mode><MVE_vpred>` for operand[3] uses s_register_operand which allows subreg but then it creates a VPSELQ_S unspec which uses vpr_register_operand as the operand which does not allow subreg and does not forces into a register. So you should create/open a bug report against the arm backend. Thanks, Andrew Pinski > > [1] > https://ci.linaro.org/job/tcwg_gnu_embed_check_gcc--master-thumb_m55_hard_eabi-build/517/artifact/artifacts/00-sumfiles/
