On 7/18/24 8:23 AM, Segher Boessenkool wrote:
> Everything in gcc.target/powerpc is only run for target powerpc*-*-*
> anyway, so make this just
>
> /* { dg-do compile } */
>
> please. (Or nothing, it is the default after all, but you may want to
> have it explicit).
Personally, I do like seeing the /* { dg-do compile } */ even though
that is the default in this testsuite directory.
>> +/* { dg-require-effective-target powerpc_vsx_ok } */
>
> Why is this needed? It needs a comment saying that.
After Kewen's testsuite patch, powerpc_vsx_ok is pretty useless as it only
checks whether the assembler knows about vsx, and what people normally want
is powerpc_vsx which verifies that the compiler options used to compile the
test support generating VSX insns. That said, do we really need that here?
Can't we compile this test case with -mcpu=power4 as the default (ie, no
VSX) and the clones should be able to generate power* and VSX just fine,
correct? I don't understand the requirement on VSX here.
> Saying that this is "to test if can use the target attr" is nonsense.
> That does not need Linux either btw. Target selection might not work
> correctly currently on some other systems, but this is not a run test!
Agreed. Also, if the clones stuff really doesn't work for those
targets even in a compile test, then rather than diabling this way,
I think I'd like to see a target-supports clones_ok test or similar.
Peter
