Hi Peter, on 2024/7/17 21:00, Peter Bergner wrote: > On 7/17/24 4:09 AM, Kewen.Lin wrote: >> * config/rs6000/rs6000.md (@extenddf<FLOAT128:mode>2): Remove condition >> TARGET_LONG_DOUBLE_128 for FLOAT128_IEEE_P modes. > > This all LGTM, except this ChangeLog fragment doesn't match the code changes > below. Rather than removing TARGET_LONG_DOUBLE_128, you've added > FLOAT128_IEEE_P (<MODE>mode)).
Thanks for the comments! For FLOAT128_IEEE_P modes, the previous condition is (TARGET_HARD_FLOAT && TARGET_LONG_DOUBLE_128), with this change the condition becomes to TARGET_HARD_FLOAT, from this perspective it still matches. I guess you meant "Remove" is expected to remove some code explicitly and can be misleading here, if so how about "Don't check TARGET_LONG_DOUBLE_128 for FLOAT128_IEEE_P modes"? > > >> - "TARGET_HARD_FLOAT && TARGET_LONG_DOUBLE_128" >> + "TARGET_HARD_FLOAT >> + && (TARGET_LONG_DOUBLE_128 || FLOAT128_IEEE_P (<MODE>mode))" > > > Peter > BR, Kewen
