On 7/16/24 6:19 PM, Carl Love wrote:
> use __int128 types that are not supported on all platforms.  The
> __int128 type is only supported on 64-bit platforms.  Need to check that
> the platform is 64-bits and support the __int128 type.  Add the int128 and
> lp64 flags to the target test.

The test cases themselves look good, but you need to update your git log entry
to not mention the lp64/64-bits since you removed them.  Yes, currently, only
64-bit targets support __int128, but our hope is that one day, even 32-bit
targets will as well.  So how about the following text instead?


...
use __int128 types that are not supported on all platforms.  Update the
tests to check int128 effective target to avoid unsupported type errors
on unsupported platforms.


Peter

Reply via email to