Re: [PATCH] s390: Fix unresolved iterators bhfgq and xdee

[Andreas Krebbel]

On 7/16/24 10:29, Stefan Schulze Frielinghaus wrote:

Code attribute bhfgq is missing a mapping for TF.  This results in
unresolved iterators in assembler templates for *bswaptf.

With the TF mapping added the base mnemonics vlbr and vstbr are not
"used" anymore but only the extended mnemonics (vlbr<bhfgq> was
interpreted as vlbr; likewise for vstbr).  Therefore, remove the base
mnemonics from the scheduling description, otherwise, genattrtab would
error about unknown mnemonics.

Similarly, we end up with unresolved iterators in assembler templates
for mulfprx23 since code attribute xdee is missing a mapping for FPRX2.

gcc/ChangeLog:

        * config/s390/3931.md (vlbr, vstbr): Remove.
        * config/s390/s390.md (xdee): Add FPRX2 mapping.
        * config/s390/vector.md (bhfgq): Add TF mapping.

Ok. Thanks!


Andreas

---
  Bootstrapped and regtested on s390.  Ok for {mainline,12,13,14}?

  gcc/config/s390/3931.md   | 5 -----
  gcc/config/s390/s390.md   | 2 +-
  gcc/config/s390/vector.md | 2 +-
  3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/gcc/config/s390/3931.md b/gcc/config/s390/3931.md
index 632c2456b6a..9f7a4c58755 100644
--- a/gcc/config/s390/3931.md
+++ b/gcc/config/s390/3931.md
@@ -404,7 +404,6 @@ vlvgg,
  vlvgh,
  vlvgp,
  vst,
-vstbr,
  vstbrf,
  vstbrg,
  vstbrh,
@@ -627,7 +626,6 @@ tm,
  tmy,
  vl,
  vlbb,
-vlbr,
  vlbrf,
  vlbrg,
  vlbrh,
@@ -661,7 +659,6 @@ vlreph,
  vlrl,
  vlrlr,
  vst,
-vstbr,
  vstbrf,
  vstbrg,
  vstbrh,
@@ -2148,7 +2145,6 @@ vistrfs,
  vistrhs,
  vl,
  vlbb,
-vlbr,
  vlbrf,
  vlbrg,
  vlbrh,
@@ -2240,7 +2236,6 @@ tbegin,
  tbeginc,
  tend,
  vst,
-vstbr,
  vstbrf,
  vstbrg,
  vstbrh,
diff --git a/gcc/config/s390/s390.md b/gcc/config/s390/s390.md
index 303026f6af7..3d5759d6252 100644
--- a/gcc/config/s390/s390.md
+++ b/gcc/config/s390/s390.md
@@ -745,7 +745,7 @@
  ;; In FP templates, a <dee> in "m<dee><bt>r" will expand to "mx<bt>r" in
  ;; TF/TDmode, "md<bt>r" in DF/DDmode, "mee<bt>r" in SFmode and "me<bt>r in
  ;; SDmode.
-(define_mode_attr xdee [(TF "x") (DF "d") (SF "ee") (TD "x") (DD "d") (SD 
"e")])
+(define_mode_attr xdee [(TF "x") (FPRX2 "x") (DF "d") (SF "ee") (TD "x") (DD "d") (SD 
"e")])

;; The decimal floating point variants of add, sub, div and mul support 3

  ;; fp register operands.  The following attributes allow to merge the bfp and
diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md
index 63678859657..cca9e3556c9 100644
--- a/gcc/config/s390/vector.md
+++ b/gcc/config/s390/vector.md
@@ -136,7 +136,7 @@
                        (V1TI "q") (TI "q")
                        (V1SF "f") (V2SF "f") (V4SF "f")
                        (V1DF "g") (V2DF "g")
-                       (V1TF "q")])
+                       (V1TF "q") (TF "q")])

; This is for vmalhw. It gets an 'w' attached to avoid confusion with

  ; multiply and add logical high vmalh.