On Tue, Jul 16, 2024 at 4:25 PM Christoph Müllner <christoph.muell...@vrull.eu> wrote: > > On Tue, Jul 16, 2024 at 4:45 AM Kito Cheng <kito.ch...@sifive.com> wrote: > > > > On Tue, Jul 16, 2024 at 1:09 AM Christoph Müllner > > <christoph.muell...@vrull.eu> wrote: > > > > > > On Mon, Jul 15, 2024 at 11:10 AM Kito Cheng <kito.ch...@gmail.com> wrote: > > > > > > > > LGTM, and could you backport this to the GCC 14 branch as well? > > > > > > Rebased, retested (multilib), fixed an issue related to Zca/Zcd and > > > pushed. > > > > > > Should the GCC 14 backport be posted for review before pushing? > > > > I guess the patch for GCC 14 may little different than this patch > > series since Pan's rewrite isn't applied on that, > > however I trust you will handle this well, so pre-approved for that :P > > The hashtable rewrite is on GCC 14: > git branch -a --contains 9941f0295a14659e25260458efd2e46a68ad0342 > [...] > remotes/origin/master > remotes/origin/releases/gcc-14 > [...] > > So the backport to GCC 14 would include all patches of this series > with the exception of the alloca() patch. > Adjustments are just needed for some of the tests, because "rv64gc" expands > to less instruction sets in GCC14 (no zaamo1p0_zalrsc1p0_zca1p0_zcd1p0). > I've already cherry-picked, adjusted and successfully tested that and > will push if that's ok.
Yeah, I am ok with that :) > > BTW, I accidentally pushed the alloca()-patch to master. > But I reverted that as soon as I noticed my mistake. > Apologies for that! > > > > > but don't forget to send committed patches to the mailing list (with > > [committed][GCC-14] prefix in the title), so that we know you are done > > :)
