> -----Original Message-----
> From: Andrew Pinski (QUIC) <quic_apin...@quicinc.com>
> Sent: Saturday, June 22, 2024 7:25 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Andrew Pinski (QUIC) <quic_apin...@quicinc.com>
> Subject: [PATCH] Ranger: Mark a few classes as final
> 
> I noticed there was a warning from clang about int_range's
> dtor being marked as final saying the class cannot be inherited
> from.
> So let's mark the few ranger classes as final for those which
> we know will be final.
> 
> Bootstrapped and tested on x86_64-linux-gnu.

Ping?

> 
> gcc/ChangeLog:
> 
>       * value-range.h (class int_range): Mark as final.
>       (class prange): Likewise.
>       (class frange): Likewise.
> 
> Signed-off-by: Andrew Pinski <quic_apin...@quicinc.com>
> ---
>  gcc/value-range.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/gcc/value-range.h b/gcc/value-range.h index
> 4a8d69f3408..334ea1bc338 100644
> --- a/gcc/value-range.h
> +++ b/gcc/value-range.h
> @@ -363,7 +363,7 @@ protected:
>  // HARD_MAX_RANGES.  This new storage is freed upon
> destruction.
> 
>  template<unsigned N, bool RESIZABLE = false> -class
> int_range : public irange
> +class int_range final : public irange
>  {
>  public:
>    int_range ();
> @@ -380,7 +380,7 @@ private:
>    wide_int m_ranges[N*2];
>  };
> 
> -class prange : public vrange
> +class prange final : public vrange
>  {
>    friend class prange_storage;
>    friend class vrange_printer;
> @@ -523,7 +523,7 @@ nan_state::neg_p () const  // The
> representation is a type with a couple of endpoints, unioned
> // with the set of { -NAN, +Nan }.
> 
> -class frange : public vrange
> +class frange final : public vrange
>  {
>    friend class frange_storage;
>    friend class vrange_printer;
> --
> 2.43.0

Reply via email to