Hi, on 2024/7/4 07:33, Carl Love wrote: > GCC maintainers: > > Per the comments on patch 2 from version 4, I have moved the removal of > built-ins __builtin_vsx_xvcvdpsxws and __builtin_vsx_xvcvdpuxws from patch 4 > to this patch. > > Please let me know if this patch is acceptable. Thanks. > > Carl > > ---------------------------------------------------------------- > > rs6000, __builtin_vsx_xvcv{sp{sx,u}ws,dpuxds_uns}
Nit: uncomplete subject rs6000: Remove built-ins __builtin_vsx_xvcv{sp{sx,u}ws,dpuxds_uns} OK for trunk with this nit fixed, thanks! BR, Kewen > > The built-in __builtin_vsx_xvcvspsxws is covered by built-in vec_signed > built-in that is documented in the PVIPR. The __builtin_vsx_xvcvspsxws > built-in is not documented and there are no test cases for it. > > The built-in __builtin_vsx_xvcvdpuxds_uns is redundant as it is covered by > vec_unsigned, remove. > > The __builtin_vsx_xvcvspuxws is redundant as it is covered by > vec_unsigned, remove. > > The built-in __builtin_vsx_xvcvdpsxws is redundant as it is covered by > vec_signed{e,o}, remove. > > The built-in __builtin_vsx_xvcvdpuxws is redundant as it is covered by > vec_unsigned{e,o}, remove. > > This patch removes the redundant built-ins. > > gcc/ChangeLog: > * config/rs6000/rs6000-builtins.def (__builtin_vsx_xvcvspsxws, > __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws, > __builtin_vsx_xvcvdpsxws, __builtin_vsx_xvcvdpuxws): Remove > built-in definitions. > --- > gcc/config/rs6000/rs6000-builtins.def | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtins.def > b/gcc/config/rs6000/rs6000-builtins.def > index 7c36976a089..60ccc5542be 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -1688,36 +1688,21 @@ > const vsll __builtin_vsx_xvcvdpsxds_scale (vd, const int); > XVCVDPSXDS_SCALE vsx_xvcvdpsxds_scale {} > > - const vsi __builtin_vsx_xvcvdpsxws (vd); > - XVCVDPSXWS vsx_xvcvdpsxws {} > - > const vsll __builtin_vsx_xvcvdpuxds (vd); > XVCVDPUXDS vsx_fixuns_truncv2dfv2di2 {} > > const vsll __builtin_vsx_xvcvdpuxds_scale (vd, const int); > XVCVDPUXDS_SCALE vsx_xvcvdpuxds_scale {} > > - const vull __builtin_vsx_xvcvdpuxds_uns (vd); > - XVCVDPUXDS_UNS vsx_fixuns_truncv2dfv2di2 {} > - > - const vsi __builtin_vsx_xvcvdpuxws (vd); > - XVCVDPUXWS vsx_xvcvdpuxws {} > - > const vd __builtin_vsx_xvcvspdp (vf); > XVCVSPDP vsx_xvcvspdp {} > > const vsll __builtin_vsx_xvcvspsxds (vf); > XVCVSPSXDS vsx_xvcvspsxds {} > > - const vsi __builtin_vsx_xvcvspsxws (vf); > - XVCVSPSXWS vsx_fix_truncv4sfv4si2 {} > - > const vsll __builtin_vsx_xvcvspuxds (vf); > XVCVSPUXDS vsx_xvcvspuxds {} > > - const vsi __builtin_vsx_xvcvspuxws (vf); > - XVCVSPUXWS vsx_fixuns_truncv4sfv4si2 {} > - > const vd __builtin_vsx_xvcvsxddp (vsll); > XVCVSXDDP vsx_floatv2div2df2 {} >