> On 3 Jul 2024, at 11:59, Kyrylo Tkachov <ktkac...@nvidia.com> wrote: > > External email: Use caution opening links or attachments > > > Hi all, > > The ACLE asks the user to test for __ARM_FEATURE_BF16 before using the > <arm_bf16.h> header but GCC doesn't set this up. > LLVM does, so this is an inconsistency between the compilers. > > This patch enables that macro for TARGET_BF16_FP. > Bootstrapped and tested on aarch64-none-linux-gnu. > Pushing to trunk. > I think it makes sense to back port this to branches that support the > arm_bf16.h header. > I’ll prepare patches for those separately. > > Thanks, > Kyrill > > gcc/ > > PR target/115457 > * config/aarch64/aarch64-c.c (aarch64_update_cpp_builtins): > Define __ARM_FEATURE_BF16 for TARGET_BF16_FP.
This should be aarch64-c.cc <http://aarch64-c.cc/> of course. I’ve fixed that up on commit and in the second patch too. Thanks, Kyrill > > gcc/testsuite/ > > PR target/115457 > * gcc.target/aarch64/acle/bf16_feature.c: New test. > > Signed-off-by: Kyrylo Tkachov <ktkac...@nvidia.com> > <0001-aarch64-PR-target-115457-Implement-missing-__ARM_FEA.patch>
