Can this process be a little bit simpler in the future? Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Christophe Lyon <christophe.l...@linaro.org> Sent: Thursday, June 27, 2024 5:30:47 AM To: Evgeny Karpov <evgeny.kar...@microsoft.com> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; ubiz...@gmail.com <ubiz...@gmail.com>; richard.sandif...@arm.com <richard.sandif...@arm.com>; Richard Earnshaw (lists) <richard.earns...@arm.com>; Maxim Kuvyrkov <maxim.kuvyr...@linaro.org>; Radek Barton <radek.bar...@microsoft.com>; Andrew Pinski <pins...@gmail.com>; zhendong...@inf.ethz.ch <zhendong...@inf.ethz.ch>; sja...@gcc.gnu.org <sja...@gcc.gnu.org>; rgue...@gcc.gnu.org <rgue...@gcc.gnu.org>; dmalc...@gcc.gnu.org <dmalc...@gcc.gnu.org>; xry...@gcc.gnu.org <xry...@gcc.gnu.org>; unlv...@live.com <unlv...@live.com>; sly...@gcc.gnu.org <sly...@gcc.gnu.org> Subject: Re: [PATCH] i386: Fix regression after refactoring legitimize_pe_coff_symbol, ix86_GOT_alias_set and PE_COFF_LEGITIMIZE_EXTERN_DECL
Hi Evgeny, Minor comments: - the patch title should end with [PRnnnnn, ...] (choose the most relevant bug number) - ChangeLog should mention every bug with PR component/nnnnn so that the bugzilla hooks will notice the commit. See https://gcc.gnu.org/contribute.html#patches (but I can do it for you before pushing the patch) Thanks, Christophe On Thu, 27 Jun 2024 at 09:16, Evgeny Karpov <evgeny.kar...@microsoft.com> wrote: > > Thank you for reporting the issues and discussing the root causes. > It helped in preparing the patch. > > This patch fixes 3 bugs reported after merging > the "Add DLL import/export implementation to AArch64" series. > https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653955.html > The series refactors the i386 codebase to reuse it in AArch64, which > triggers some bugs. > > Bug 115661 - [15 Regression] wrong code at -O{2,3} on > x86_64-linux-gnu since r15-1599-g63512c72df09b4 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115661 > > Bug 115635 - [15 regression] Bootstrap fails with failed > self-test with the rust fe (diagnostic-path.cc:1153: > test_empty_path: FAIL: ASSERT_FALSE > ((path.interprocedural_p ()))) since r15-1599-g63512c72df09b4 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115635 > > Issue 1. In some code, i386 has been relying on the > legitimize_pe_coff_symbol call on all platforms and should return > NULL_RTX if it is not supported. > > Fix: NULL_RTX handling has been added when the target does not > support PECOFF. > > Issue 2. ix86_GOT_alias_set is used on all platforms and cannot be > extracted to mingw. > > Fix: ix86_GOT_alias_set has been returned as it was and is used on > all platforms for i386. > > Bug 115643 - [15 regression] aarch64-w64-mingw32 support today breaks > x86_64-w64-mingw32 build cannot represent relocation type > BFD_RELOC_64 since r15-1602-ged20feebd9ea31 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115643 > > Issue 3. PE_COFF_EXTERN_DECL_SHOULD_BE_LEGITIMIZED has been added and used > with a negative operator for a complex expression without braces. > > Fix: Braces has been added, and > PE_COFF_EXTERN_DECL_SHOULD_BE_LEGITIMIZED has been renamed to > PE_COFF_LEGITIMIZE_EXTERN_DECL. > > > The patch has been attached as a text file because it contains special > characters that are usually removed by the mail client. > > Regards, > Evgeny
