Hi Segher,
on 2024/6/21 01:20, Segher Boessenkool wrote:
> Hi!
>
> On Thu, Jun 20, 2024 at 06:22:07PM +0800, Kewen.Lin wrote:
>> Following your review comments in [1], this patch is
>> separated from Xionghu's patch v4 [2] and mainly targetted
>> for 32-bit element size, it changes with the generic call
>> altivec_vmrg*w in vec_widen_[su]mult_{hi,lo}* expanders as
>> well. If this patch looks good to you, I'll post the others
>> for 16 and 8 bits element size.
>
> This looks good. Thank you! It still is kinda big, but it is
> manageable now :-)
>
>> btw, there are still something that can be improved like
>> the loose predicates pointed out by Peter, vsx_xxmrg[hl]w_*
>> can be merged with altivec_vmrg*w etc., but I think we want
>> this one to focus on fixing regression and those enhancements
>> can be supported by some separated follow-up patches.
>
> Yeah, separate patches, either after or before these, whatever works
> best for you :-)
OK, I'll make it after these by considering their priority. :)
>
>> Bootstrapped and regtested on powerpc64-linux-gnu P8/P9
>> and powerpc64le-linux-gnu P9 and P10.
>
> That also tested -m32 (on BE at least), right?
Yes, BE testings were with unix'{-m64,-m32}'.
>
> Okay for trunk, thanks for dealing with this!
Thanks! Pushed as r15-1504! Will backport after burn-in time.
BR,
Kewen
