On Mon, Jun 18, 2012 at 10:01 PM, Janis Johnson <janis_john...@mentor.com> wrote: > On 06/17/2012 05:03 AM, Richard Guenther wrote: >> On Sun, Jun 17, 2012 at 10:41 AM, Uros Bizjak <ubiz...@gmail.com> wrote: >>> Hello! >>> >>> The testcase still fails on x86_64-pc-linux-gnu with: >>> >>> FAIL: gcc.dg/tree-ssa/vrp68.c scan-tree-dump-times vrp1 "link_error" 1 >>> >>> since there are two calls to link_error. >> >> Oops. I wonder how I did not see those failures myself ... >> >> Richard. > > I'm confused about what this test is supposed to do. It uses > "dg-do link" which means the compile (test for excess errors) will > fail if there is a reference to link_error. There are two uses of > scan-tree-dump-times for the same string in the same file, so one > of those is guaranteed to fail. It looks like the scans aren't > needed, and "dg-do link" is the thing that needs the xfail.
No, the scan-tree-dump-times are supposed to catch that already VRP1 has done the optimization - it does not so fully, which is why I added the XFAILed scan-tree-dump-times. But we still catch that XFAILed case with subsequent optimizations so the link succeeds nevertheless. The testcase fails now, I must have broken the optimization somehow and I am looking into it. Richard. > Janis
