On Fri, Jun 15, 2012 at 5:00 PM, Ulrich Weigand <uweig...@de.ibm.com> wrote: > Richard Guenther wrote: >> On Fri, Jun 15, 2012 at 3:13 PM, Ulrich Weigand <uweig...@de.ibm.com> wrote: >> > However, there is a second case where we need to check every pass: if >> > we're not actually vectorizing any loop, but are performing basic-block >> > SLP. In this case, it would appear that we need the same check as >> > described in the comment above, i.e. to verify that the stride is a >> > multiple of the vector size. >> > >> > The patch below adds this check, and this indeed fixes the invalid access >> > I was seeing in the test case (in the final assembler, we now get a >> > vld1.16 instead of vldr). >> > >> > Tested on arm-linux-gnueabi with no regressions. >> > >> > OK for mainline? >> >> Ok. > > Thanks for the quick review; I've checked this in to mainline now. > > I just noticed that the test case also crashes on 4.7, but not on 4.6. > > Would a backport to 4.7 also be OK, once testing passes?
Yes. Please leave it on mainline a few days to catch fallout from autotesters. Thanks, Richard. > Thanks, > Ulrich > > -- > Dr. Ulrich Weigand > GNU Toolchain for Linux on System z and Cell BE > ulrich.weig...@de.ibm.com >
