> Since you are moving it to torture, please remove -O3 as it is already > supplied there as one of the torture options.
Oh, I see. Thanks for comments, and will update it in v2. Pan From: Andrew Pinski <pins...@gmail.com> Sent: Tuesday, June 11, 2024 9:45 PM To: Li, Pan2 <pan2...@intel.com> Cc: GCC Patches <gcc-patches@gcc.gnu.org>; 钟居哲 <juzhe.zh...@rivai.ai>; Kito Cheng <kito.ch...@gmail.com>; Richard Guenther <richard.guent...@gmail.com>; Jeff Law <jeffreya...@gmail.com> Subject: Re: [PATCH v1] Test: Move target independent test cases to gcc.dg/torture On Mon, Jun 10, 2024, 11:20 PM <pan2...@intel.com<mailto:pan2...@intel.com>> wrote: From: Pan Li <pan2...@intel.com<mailto:pan2...@intel.com>> The test cases of pr115387 are target independent, at least x86 and riscv are able to reproduce. Thus, move these cases to the gcc.dg/torture. The below test suites are passed. 1. The rv64gcv fully regression test. 2. The x86 fully regression test. gcc/testsuite/ChangeLog: * gcc.target/riscv/pr115387-1.c: Move to... * gcc.dg/torture/pr115387-1.c: ...here. * gcc.target/riscv/pr115387-2.c: Move to... * gcc.dg/torture/pr115387-2.c: ...here. Signed-off-by: Pan Li <pan2...@intel.com<mailto:pan2...@intel.com>> --- gcc/testsuite/{gcc.target/riscv => gcc.dg/torture}/pr115387-1.c | 2 +- gcc/testsuite/{gcc.target/riscv => gcc.dg/torture}/pr115387-2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename gcc/testsuite/{gcc.target/riscv => gcc.dg/torture}/pr115387-1.c (92%) rename gcc/testsuite/{gcc.target/riscv => gcc.dg/torture}/pr115387-2.c (84%) diff --git a/gcc/testsuite/gcc.target/riscv/pr115387-1.c b/gcc/testsuite/gcc.dg/torture/pr115387-1.c similarity index 92% rename from gcc/testsuite/gcc.target/riscv/pr115387-1.c rename to gcc/testsuite/gcc.dg/torture/pr115387-1.c index a1c926977c4..fde79f66757 100644 --- a/gcc/testsuite/gcc.target/riscv/pr115387-1.c +++ b/gcc/testsuite/gcc.dg/torture/pr115387-1.c @@ -1,6 +1,6 @@ /* Test there is no ICE when compile. */ /* { dg-do compile } */ -/* { dg-options "-march=rv64gcv -mabi=lp64d -O3" } */ +/* { dg-options "-O3" } */ Since you are moving it to torture, please remove -O3 as it is already supplied there as one of the torture options. #define PRINTF_CHK 0x34 diff --git a/gcc/testsuite/gcc.target/riscv/pr115387-2.c b/gcc/testsuite/gcc.dg/torture/pr115387-2.c similarity index 84% rename from gcc/testsuite/gcc.target/riscv/pr115387-2.c rename to gcc/testsuite/gcc.dg/torture/pr115387-2.c index 7183bf18dfd..0cb4b48d27b 100644 --- a/gcc/testsuite/gcc.target/riscv/pr115387-2.c +++ b/gcc/testsuite/gcc.dg/torture/pr115387-2.c @@ -1,6 +1,6 @@ /* Test there is no ICE when compile. */ /* { dg-do compile } */ -/* { dg-options "-march=rv64gcv -mabi=lp64d -O3" } */ +/* { dg-options "-O3" } */ #include <stddef.h> #include <stdint-gcc.h> -- 2.34.1
